CSS override to fix table rendering in sect 7. #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivoatex usually puts rules above and below tabular-s, and that doesn't work for the pseudo tables used there.
tomdonaldson
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
While this is a bit hacky, I think the results are enough of an improvement to be worth the hack.
I note that compared to prior versions, lines between rows are now missing in section 7 (the problem area) and in sections 2 and 2.1. I don't think this hurts the readability, so it's OK, but an example of side effects we should be aware of.
This addresses the extra lines portion of #63 but we'll leave that open as there still may be an issue (at least on my Mac) with the fonts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ivoatex usually puts rules above and below tabular-s, and that doesn't work for the pseudo tables used there.
This is a fairly lame fix that requires an extra file and, horror, an
!importantwithin the CSS.If you consider this to be too abhorrent, I'd be ok with doing a fix within ivoatex, but for now I think the present horror is an artefact of an abuse of tables, and hence I'm reluctant to spend time on a good fix.